From 91807aac61963d32af19b6e4b27c46d6845e4e78 Mon Sep 17 00:00:00 2001 From: Gareth Pendleton Date: Sun, 19 Oct 2025 19:16:33 +0100 Subject: [PATCH] perf: Removed erlang/js specific parsing This currently seems to compile exactly the same in 1.12.0 and 1.13.0 so therefore has a performance regression --- src/gluri/internal/parser.gleam | 117 -------------------------------- src/gluri/internal/utils.gleam | 31 --------- 2 files changed, 148 deletions(-) diff --git a/src/gluri/internal/parser.gleam b/src/gluri/internal/parser.gleam index ad71f90..0dfd4d4 100644 --- a/src/gluri/internal/parser.gleam +++ b/src/gluri/internal/parser.gleam @@ -729,25 +729,6 @@ fn parse_unreserved(str: String) -> Result(#(String, String), Nil) { // / "*" / "+" / "," / ";" / "=" // %21 / %24 / %26 / %27 / %28 / %29 // / %2A / %2B / %2C / %3B / %3D -@target(erlang) -fn parse_sub_delim(str: String) -> Result(#(String, String), Nil) { - case string.pop_grapheme(str) { - Ok(#("!" as char, tail)) - | Ok(#("$" as char, tail)) - | Ok(#("&" as char, tail)) - | Ok(#("'" as char, tail)) - | Ok(#("(" as char, tail)) - | Ok(#(")" as char, tail)) - | Ok(#("*" as char, tail)) - | Ok(#("+" as char, tail)) - | Ok(#("," as char, tail)) - | Ok(#(";" as char, tail)) - | Ok(#("=" as char, tail)) -> Ok(#(char, tail)) - _ -> Error(Nil) - } -} - -@target(javascript) fn parse_sub_delim(str: String) -> Result(#(String, String), Nil) { case str { "!" as char <> tail @@ -766,25 +747,6 @@ fn parse_sub_delim(str: String) -> Result(#(String, String), Nil) { } // DIGIT = %x30–39 -@target(erlang) -fn parse_digit(str: String) -> Result(#(String, String), Nil) { - case string.pop_grapheme(str) { - Ok(#("0" as char, tail)) - | Ok(#("1" as char, tail)) - | Ok(#("2" as char, tail)) - | Ok(#("3" as char, tail)) - | Ok(#("4" as char, tail)) - | Ok(#("5" as char, tail)) - | Ok(#("6" as char, tail)) - | Ok(#("7" as char, tail)) - | Ok(#("8" as char, tail)) - | Ok(#("9" as char, tail)) -> Ok(#(char, tail)) - - _ -> Error(Nil) - } -} - -@target(javascript) fn parse_digit(str: String) -> Result(#(String, String), Nil) { case str { "0" as char <> tail @@ -803,24 +765,6 @@ fn parse_digit(str: String) -> Result(#(String, String), Nil) { } // DIGIT (non-zero) = %x31–39 -@target(erlang) -fn parse_digit_nz(str: String) -> Result(#(String, String), Nil) { - case string.pop_grapheme(str) { - Ok(#("1" as char, tail)) - | Ok(#("2" as char, tail)) - | Ok(#("3" as char, tail)) - | Ok(#("4" as char, tail)) - | Ok(#("5" as char, tail)) - | Ok(#("6" as char, tail)) - | Ok(#("7" as char, tail)) - | Ok(#("8" as char, tail)) - | Ok(#("9" as char, tail)) -> Ok(#(char, tail)) - - _ -> Error(Nil) - } -} - -@target(javascript) fn parse_digit_nz(str: String) -> Result(#(String, String), Nil) { case str { "1" as char <> tail @@ -847,67 +791,6 @@ fn parse_digits(str: String, digits: String) { } // ALPHA = %x41–5A | %x61–7A -@target(erlang) -fn parse_alpha(str: String) -> Result(#(String, String), Nil) { - case string.pop_grapheme(str) { - Ok(#("a" as char, tail)) - | Ok(#("b" as char, tail)) - | Ok(#("c" as char, tail)) - | Ok(#("d" as char, tail)) - | Ok(#("e" as char, tail)) - | Ok(#("f" as char, tail)) - | Ok(#("g" as char, tail)) - | Ok(#("h" as char, tail)) - | Ok(#("i" as char, tail)) - | Ok(#("j" as char, tail)) - | Ok(#("k" as char, tail)) - | Ok(#("l" as char, tail)) - | Ok(#("m" as char, tail)) - | Ok(#("n" as char, tail)) - | Ok(#("o" as char, tail)) - | Ok(#("p" as char, tail)) - | Ok(#("q" as char, tail)) - | Ok(#("r" as char, tail)) - | Ok(#("s" as char, tail)) - | Ok(#("t" as char, tail)) - | Ok(#("u" as char, tail)) - | Ok(#("v" as char, tail)) - | Ok(#("w" as char, tail)) - | Ok(#("x" as char, tail)) - | Ok(#("y" as char, tail)) - | Ok(#("z" as char, tail)) - | Ok(#("A" as char, tail)) - | Ok(#("B" as char, tail)) - | Ok(#("C" as char, tail)) - | Ok(#("D" as char, tail)) - | Ok(#("E" as char, tail)) - | Ok(#("F" as char, tail)) - | Ok(#("G" as char, tail)) - | Ok(#("H" as char, tail)) - | Ok(#("I" as char, tail)) - | Ok(#("J" as char, tail)) - | Ok(#("K" as char, tail)) - | Ok(#("L" as char, tail)) - | Ok(#("M" as char, tail)) - | Ok(#("N" as char, tail)) - | Ok(#("O" as char, tail)) - | Ok(#("P" as char, tail)) - | Ok(#("Q" as char, tail)) - | Ok(#("R" as char, tail)) - | Ok(#("S" as char, tail)) - | Ok(#("T" as char, tail)) - | Ok(#("U" as char, tail)) - | Ok(#("V" as char, tail)) - | Ok(#("W" as char, tail)) - | Ok(#("X" as char, tail)) - | Ok(#("Y" as char, tail)) - | Ok(#("Z" as char, tail)) -> Ok(#(char, tail)) - - _ -> Error(Nil) - } -} - -@target(javascript) fn parse_alpha(str: String) -> Result(#(String, String), Nil) { case str { "a" as char <> tail diff --git a/src/gluri/internal/utils.gleam b/src/gluri/internal/utils.gleam index d49483f..4e54d8e 100644 --- a/src/gluri/internal/utils.gleam +++ b/src/gluri/internal/utils.gleam @@ -370,37 +370,6 @@ fn unescape_percent(str: String) -> String { } } -@target(erlang) -pub fn parse_hex_digit(str: String) -> Result(#(String, String), Nil) { - case string.pop_grapheme(str) { - Ok(#("0" as char, tail)) - | Ok(#("1" as char, tail)) - | Ok(#("2" as char, tail)) - | Ok(#("3" as char, tail)) - | Ok(#("4" as char, tail)) - | Ok(#("5" as char, tail)) - | Ok(#("6" as char, tail)) - | Ok(#("7" as char, tail)) - | Ok(#("8" as char, tail)) - | Ok(#("9" as char, tail)) - | Ok(#("a" as char, tail)) - | Ok(#("b" as char, tail)) - | Ok(#("c" as char, tail)) - | Ok(#("d" as char, tail)) - | Ok(#("e" as char, tail)) - | Ok(#("f" as char, tail)) - | Ok(#("A" as char, tail)) - | Ok(#("B" as char, tail)) - | Ok(#("C" as char, tail)) - | Ok(#("D" as char, tail)) - | Ok(#("E" as char, tail)) - | Ok(#("F" as char, tail)) -> Ok(#(char, tail)) - - _ -> Error(Nil) - } -} - -@target(javascript) pub fn parse_hex_digit(str: String) -> Result(#(String, String), Nil) { case str { "0" as char <> tail